Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make release-test: no more eggs #7957

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Apr 8, 2024

During the release, the output of make release-test includes:

Successfully installed pillow-10.4.0.dev0
rm dist/*.egg
rm: dist/*.egg: No such file or directory
make: [release-test] Error 1 (ignored)
rmdir dist
rmdir: dist: No such file or directory
make: [release-test] Error 1 (ignored)
python3 -m pytest -qq

Eggs are no longer used: https://peps.python.org/pep-0715/

Let's remove -rm dist/*.egg.

@radarhere
Copy link
Member

The PEP you've linked to talks about eggs in relation to PyPI, but why are they no longer being created by Pillow?

The line was originally added in #4992, to resolve #4981. So what changed between then and now?

@hugovk
Copy link
Member Author

hugovk commented Apr 11, 2024

The PEP you've linked to talks about eggs in relation to PyPI, but why are they no longer being created by Pillow?

I'm not sure. #4981 says the egg was created from the python3 setup.py install command. That command was changed to python3 -m pip install . in #5896, so it could have been that or a change in setuptools.

The line was originally added in #4992, to resolve #4981.

Yep, yhat was to prevent us uploading an egg when doing a manual release.

Now our artifacts are all generated and released from CI, so it wouldn't even matter if an egg ended up in a local dist/ when running make release-test.

@radarhere radarhere merged commit 3037dea into python-pillow:main Apr 13, 2024
55 of 56 checks passed
@hugovk hugovk deleted the make-release-test-eggless branch April 13, 2024 05:57
@radarhere
Copy link
Member

You're right, python3 setup.py install creates a dist egg, but python3 -m pip install . does not.

By the same token then, we also don't need to remove the dist directory any longer, so I've created #7974

@hugovk hugovk added the Cleanup label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants